Bug 144102

Summary: [GTK] Fixups for ENABLE_CREDENTIAL_STORAGE
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mcatanzaro
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2015-04-23 09:26:03 PDT
ENABLE_CREDENTIAL_STORAGE became a WebKit option in r182996 so we shouldn't set it manually anymore. Also, if ENABLE_CREDENTIAL_STORAGE is set but libsecret is not present, the build needs to fail. (We can consider giving it a nicer error message in bug #143546.)
Attachments
Patch (2.40 KB, patch)
2015-04-23 09:28 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2015-04-23 09:28:49 PDT
Created attachment 251447 [details] Patch
WebKit Commit Bot
Comment 2 2015-04-23 10:30:43 PDT
Comment on attachment 251447 [details] Patch Clearing flags on attachment: 251447 Committed r183192: <http://trac.webkit.org/changeset/183192>
WebKit Commit Bot
Comment 3 2015-04-23 10:30:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.