Bug 144090

Summary:

Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebCore Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, andersca, buildbot, kling, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

128007

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews102 for mac-mavericks	none
Archive of layout-test-results from ews106 for mac-mavericks-wk2	none
Patch	none
Patch	none

Darin Adler

Reported 2015-04-23 00:29:33 PDT

Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr

Attachments
Patch (91.66 KB, patch) 2015-04-23 00:45 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (91.71 KB, patch) 2015-04-23 00:55 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-mavericks (529.29 KB, application/zip) 2015-04-23 01:41 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (640.79 KB, application/zip) 2015-04-23 02:02 PDT, Build Bot	no flags	Details
Patch (97.55 KB, patch) 2015-04-23 07:54 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (112.09 KB, patch) 2015-04-23 09:35 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2015-04-23 00:45:47 PDT

Created attachment 251414 [details] Patch

Darin Adler

Comment 2 2015-04-23 00:55:11 PDT

Created attachment 251415 [details] Patch

Build Bot

Comment 3 2015-04-23 01:41:22 PDT

Comment on attachment 251415 [details] Patch Attachment 251415 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5624307581452288 New failing tests: http/tests/websocket/tests/hybi/zero-length-text.html

Build Bot

Comment 4 2015-04-23 01:41:26 PDT

Created attachment 251419 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 5 2015-04-23 02:02:31 PDT

Comment on attachment 251415 [details] Patch Attachment 251415 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6000555306516480 New failing tests: http/tests/websocket/tests/hybi/zero-length-text.html

Build Bot

Comment 6 2015-04-23 02:02:34 PDT

Created attachment 251422 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Darin Adler

Comment 7 2015-04-23 07:54:57 PDT

Created attachment 251435 [details] Patch

Darin Adler

Comment 8 2015-04-23 09:35:22 PDT

Created attachment 251449 [details] Patch

Darin Adler

Comment 9 2015-04-23 09:38:43 PDT

Comment on attachment 251449 [details] Patch Anders already reviewed. If Windows builds then I will land.

Darin Adler

Comment 10 2015-04-23 19:14:48 PDT

Committed r183234: <http://trac.webkit.org/changeset/183234>

Andy Estes

Comment 11 2015-04-23 20:25:54 PDT

(In reply to comment #9) > Comment on attachment 251449 [details] > Patch > > Anders already reviewed. If Windows builds then I will land. > > Committed r183234: <http://trac.webkit.org/changeset/183234> Windows didn't build. But to be fair, you never said you wouldn't land if it didn't :)

Andy Estes

Comment 12 2015-04-23 20:50:55 PDT

Speculative build fix: http://trac.webkit.org/changeset/183239

Andy Estes

Comment 13 2015-04-23 21:57:40 PDT

iOS debug build fix: http://trac.webkit.org/changeset/183244

Darin Adler

Comment 14 2015-04-23 22:47:38 PDT

Thanks for those fixes, Andy.

Note You need to log in before you can comment on or make changes to this bug.