Bug 144089

Summary:

[WK2] WebDiagnosticLoggingClient is leaking

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit2

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, barraclough, commit-queue, japhet, kling, sam

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2015-04-22 22:36:15 PDT

WebDiagnosticLoggingClient is leaking. It is constructed inside the WebPage constructor but there is no code destroying it.
We should add a new xxxDestroyed() virtual function that calls "delete this" in WebDiagnosticLoggingClient, similarly to what is done for other WK2 clients.

Radar: <rdar://problem/19706214>

Comment 1 Chris Dumez 2015-04-22 23:18:15 PDT

Created attachment 251410 [details]
Patch

Comment 2 WebKit Commit Bot 2015-04-23 01:13:40 PDT

Comment on attachment 251410 [details]
Patch

Clearing flags on attachment: 251410

Committed r183179: <http://trac.webkit.org/changeset/183179>

Comment 3 WebKit Commit Bot 2015-04-23 01:13:45 PDT

All reviewed patches have been landed.  Closing bug.