| Summary: | [EFL] Build failure to find gio-unix | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Doug Newgard <scimmia22> | ||||||
| Component: | WebKit EFL | Assignee: | Ryuan Choi <ryuan.choi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, lucas.de.marchi, ryuan.choi, scimmia22 | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Attachments: |
|
||||||||
Can you update the patch with ChangeLog? You should touch ChangeLog in root directory. http://www.webkit.org/coding/contributing.html Unfortunately, not very well. The scripts you pointed me to aren't running for me. The repo layout is kind of ridiculous, so I only have a partial checkouts. Created attachment 251945 [details]
Patch
(In reply to comment #2) > Unfortunately, not very well. The scripts you pointed me to aren't running > for me. The repo layout is kind of ridiculous, so I only have a partial > checkouts. OK, I uploaded the patch with changelog instead of you. Comment on attachment 251945 [details]
Patch
Thank you for fixing.
Comment on attachment 251945 [details] Patch Clearing flags on attachment: 251945 Committed r183545: <http://trac.webkit.org/changeset/183545> All reviewed patches have been landed. Closing bug. |
Created attachment 251392 [details] Move geoclue block before find_package(GLIB...) Currently the gio-unix headers do not get included, leading to a build failure when building geoclue support. Patch attached fixes it.