Bug 144083

Summary: [EFL] Build failure to find gio-unix
Product: WebKit Reporter: Doug Newgard <scimmia22>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi, ryuan.choi, scimmia22
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Move geoclue block before find_package(GLIB...)
none
Patch none

Doug Newgard
Reported 2015-04-22 18:09:19 PDT
Created attachment 251392 [details] Move geoclue block before find_package(GLIB...) Currently the gio-unix headers do not get included, leading to a build failure when building geoclue support. Patch attached fixes it.
Attachments
Move geoclue block before find_package(GLIB...) (1.11 KB, patch)
2015-04-22 18:09 PDT, Doug Newgard 		no flags
DetailsFormatted DiffDiff
Patch (1.92 KB, patch)
2015-04-29 04:52 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2015-04-28 18:08:27 PDT
Can you update the patch with ChangeLog? You should touch ChangeLog in root directory. http://www.webkit.org/coding/contributing.html
Doug Newgard
Comment 2 2015-04-28 19:06:05 PDT
Unfortunately, not very well. The scripts you pointed me to aren't running for me. The repo layout is kind of ridiculous, so I only have a partial checkouts.
Ryuan Choi
Comment 3 2015-04-29 04:52:08 PDT
Created attachment 251945 [details] Patch
Ryuan Choi
Comment 4 2015-04-29 04:52:53 PDT
(In reply to comment #2) > Unfortunately, not very well. The scripts you pointed me to aren't running > for me. The repo layout is kind of ridiculous, so I only have a partial > checkouts. OK, I uploaded the patch with changelog instead of you.
Gyuyoung Kim
Comment 5 2015-04-29 05:23:45 PDT
Comment on attachment 251945 [details] Patch Thank you for fixing.
WebKit Commit Bot
Comment 6 2015-04-29 07:36:10 PDT
Comment on attachment 251945 [details] Patch Clearing flags on attachment: 251945 Committed r183545: <http://trac.webkit.org/changeset/183545>
WebKit Commit Bot
Comment 7 2015-04-29 07:36:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.