| Summary: | There should only be one way to get the system memory size. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
| Component: | Web Template Framework | Assignee: | Andreas Kling <kling> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, kling | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andreas Kling
2015-04-22 17:22:28 PDT
Tim pointed out that WTF already has ramSize(). So let's try using that everywhere! Created attachment 251411 [details]
Patch
Attachment 251411 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/RAMSize.cpp:33: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WTF/wtf/RAMSize.cpp:91: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:54: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm:36: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 4 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 251413 [details]
Patch
Attachment 251413 [details] did not pass style-queue:
ERROR: Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:54: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r183181: <http://trac.webkit.org/changeset/183181> This seems to be creating a build failure: /Volumes/Data/slave/yosemite-release/build/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:58:9: fatal error: 'wtf/RamSize.h' file not found Started fixing the build in <http://trac.webkit.org/r183188>. There may be more... |