Summary: | Provide a runtime flag to run-webkit-tests that shows the test view | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||
Component: | Tools / Tests | Assignee: | Brent Fulgham <bfulgham> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 144588, 144589, 144621 | ||||||||
Attachments: |
|
Description
Brent Fulgham
2015-04-22 16:26:44 PDT
Skipping TestWebKitAPI for now, since it doesn't process its own arguments (it's all driven by the Google test infrastructure. Since this is only needed for debugging while creating tests, we will invoke it via the "--additional-drt-flag" option: --additional-drt-flag="--show-webview" Created attachment 252078 [details]
Patch
Comment on attachment 252078 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252078&action=review > Tools/WebKitTestRunner/Options.cpp:115 > + if (option[0] && option[1] && option[0] == '-' && option[1] == '-') > + return true; Why this bit? It's different from how handleOptionRemoteLayerTree works. > Tools/WebKitTestRunner/TestInvocation.cpp:180 > + WKRetainPtr<WKStringRef> shouldShowWebViewKey(AdoptWK, WKStringCreateWithUTF8CString("ShouldShowWebView")); > + WKRetainPtr<WKBooleanRef> shouldShowWebViewValue = adoptWK(WKBooleanCreate(TestController::singleton().shouldShowWebView())); > + WKDictionarySetItem(beginTestMessageBody.get(), shouldShowWebViewKey.get(), shouldShowWebViewValue.get()); I don't get why these have to go to the injected bundle. We create the view in the UI process. Created attachment 252095 [details]
Patch
(In reply to comment #4) > Comment on attachment 252078 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=252078&action=review > > > Tools/WebKitTestRunner/Options.cpp:115 > > + if (option[0] && option[1] && option[0] == '-' && option[1] == '-') > > + return true; > > Why this bit? It's different from how handleOptionRemoteLayerTree works. OK -- I fixed it to be consistent with "--remote-layer-tree". > > Tools/WebKitTestRunner/TestInvocation.cpp:180 > > + WKRetainPtr<WKStringRef> shouldShowWebViewKey(AdoptWK, WKStringCreateWithUTF8CString("ShouldShowWebView")); > > + WKRetainPtr<WKBooleanRef> shouldShowWebViewValue = adoptWK(WKBooleanCreate(TestController::singleton().shouldShowWebView())); > > + WKDictionarySetItem(beginTestMessageBody.get(), shouldShowWebViewKey.get(), shouldShowWebViewValue.get()); > > I don't get why these have to go to the injected bundle. We create the view > in the UI process. I was just blindly following the "timeout" option. We don't need this for the InjectedBundle. I'll remove it. Committed r183651: <http://trac.webkit.org/changeset/183651> Follow-up correction landed in r183765: Committed r183765: <http://trac.webkit.org/changeset/183765> |