Bug 144069

Summary: [CMake] Add error checking to WEBKIT_OPTION_DEFAULT_PORT_VALUE et. al.
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: Tools / TestsAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Enhancement CC: achristensen, commit-queue, mcatanzaro, mmaxfield, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Michael Catanzaro
Reported 2015-04-22 13:46:34 PDT
The build should fail if we try to define a default value for an option that doesn't exist.
Attachments
Patch (2.11 KB, patch)
2015-12-31 07:32 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (3.04 KB, patch)
2015-12-31 08:00 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (3.73 KB, patch)
2015-12-31 08:22 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (3.68 KB, patch)
2015-12-31 08:31 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (8.16 KB, patch)
2015-12-31 09:03 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (8.91 KB, patch)
2015-12-31 09:18 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2015-04-23 09:14:32 PDT
We should do this for WEBKIT_OPTION_DEPEND and WEBKIT_OPTION_CONFLICT as well (although perhaps not for the second argument, so that you can make options depend on arbitrary cmake variables).
Michael Catanzaro
Comment 2 2015-12-31 07:25:32 PST
(In reply to comment #1) > (although perhaps not for the second argument, so that you can make > options depend on arbitrary cmake variables). We don't do this anywhere, so I'll just check to make sure they're all valid options.
Michael Catanzaro
Comment 3 2015-12-31 07:32:50 PST
Created attachment 268033 [details] Patch
Michael Catanzaro
Comment 4 2015-12-31 08:00:42 PST
Created attachment 268036 [details] Patch
Michael Catanzaro
Comment 5 2015-12-31 08:22:09 PST
Created attachment 268037 [details] Patch
Michael Catanzaro
Comment 6 2015-12-31 08:31:09 PST
Created attachment 268038 [details] Patch
Michael Catanzaro
Comment 7 2015-12-31 09:03:30 PST
Created attachment 268040 [details] Patch
Michael Catanzaro
Comment 8 2015-12-31 09:10:46 PST
Martin, I reset r? since I had to make a bunch of deletions in OptionsWindows.cmake. I also added a new option ENABLE_SVG_OTF_CONVERTER, which was set to OFF in OptionsWindows.cmake. (It would be good for someone to investigate turning this ON for Windows, which previously had this turned on at least at some point, if only for Visual Studio builds.)
Michael Catanzaro
Comment 9 2015-12-31 09:18:00 PST
Created attachment 268041 [details] Patch
WebKit Commit Bot
Comment 10 2015-12-31 10:50:30 PST
Comment on attachment 268041 [details] Patch Clearing flags on attachment: 268041 Committed r194456: <http://trac.webkit.org/changeset/194456>
WebKit Commit Bot
Comment 11 2015-12-31 10:50:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.