Summary: | [CMake] Add error checking to WEBKIT_OPTION_DEFAULT_PORT_VALUE et. al. | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||||||||||||
Component: | Tools / Tests | Assignee: | Michael Catanzaro <mcatanzaro> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Enhancement | CC: | achristensen, commit-queue, mcatanzaro, mmaxfield, mrobinson | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | PC | ||||||||||||||||
OS: | Linux | ||||||||||||||||
Attachments: |
|
Description
Michael Catanzaro
2015-04-22 13:46:34 PDT
We should do this for WEBKIT_OPTION_DEPEND and WEBKIT_OPTION_CONFLICT as well (although perhaps not for the second argument, so that you can make options depend on arbitrary cmake variables). (In reply to comment #1) > (although perhaps not for the second argument, so that you can make > options depend on arbitrary cmake variables). We don't do this anywhere, so I'll just check to make sure they're all valid options. Created attachment 268033 [details]
Patch
Created attachment 268036 [details]
Patch
Created attachment 268037 [details]
Patch
Created attachment 268038 [details]
Patch
Created attachment 268040 [details]
Patch
Martin, I reset r? since I had to make a bunch of deletions in OptionsWindows.cmake. I also added a new option ENABLE_SVG_OTF_CONVERTER, which was set to OFF in OptionsWindows.cmake. (It would be good for someone to investigate turning this ON for Windows, which previously had this turned on at least at some point, if only for Visual Studio builds.) Created attachment 268041 [details]
Patch
Comment on attachment 268041 [details] Patch Clearing flags on attachment: 268041 Committed r194456: <http://trac.webkit.org/changeset/194456> All reviewed patches have been landed. Closing bug. |