|Summary:||[CMake] Add error checking to WEBKIT_OPTION_DEFAULT_PORT_VALUE et. al.|
|Product:||WebKit||Reporter:||Michael Catanzaro <mcatanzaro>|
|Component:||Tools / Tests||Assignee:||Michael Catanzaro <mcatanzaro>|
|Severity:||Enhancement||CC:||achristensen, commit-queue, mcatanzaro, mmaxfield, mrobinson|
|Version:||528+ (Nightly build)|
Description Michael Catanzaro 2015-04-22 13:46:34 PDT
The build should fail if we try to define a default value for an option that doesn't exist.
Comment 1 Michael Catanzaro 2015-04-23 09:14:32 PDT
We should do this for WEBKIT_OPTION_DEPEND and WEBKIT_OPTION_CONFLICT as well (although perhaps not for the second argument, so that you can make options depend on arbitrary cmake variables).
Comment 2 Michael Catanzaro 2015-12-31 07:25:32 PST
(In reply to comment #1) > (although perhaps not for the second argument, so that you can make > options depend on arbitrary cmake variables). We don't do this anywhere, so I'll just check to make sure they're all valid options.
Comment 8 Michael Catanzaro 2015-12-31 09:10:46 PST
Martin, I reset r? since I had to make a bunch of deletions in OptionsWindows.cmake. I also added a new option ENABLE_SVG_OTF_CONVERTER, which was set to OFF in OptionsWindows.cmake. (It would be good for someone to investigate turning this ON for Windows, which previously had this turned on at least at some point, if only for Visual Studio builds.)
Comment 10 WebKit Commit Bot 2015-12-31 10:50:30 PST
Comment on attachment 268041 [details] Patch Clearing flags on attachment: 268041 Committed r194456: <http://trac.webkit.org/changeset/194456>
Comment 11 WebKit Commit Bot 2015-12-31 10:50:34 PST
All reviewed patches have been landed. Closing bug.