Bug 144069 - [CMake] Add error checking to WEBKIT_OPTION_DEFAULT_PORT_VALUE et. al.
Summary: [CMake] Add error checking to WEBKIT_OPTION_DEFAULT_PORT_VALUE et. al.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Enhancement
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-22 13:46 PDT by Michael Catanzaro
Modified: 2015-12-31 10:50 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.11 KB, patch)
2015-12-31 07:32 PST, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
Patch (3.04 KB, patch)
2015-12-31 08:00 PST, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
Patch (3.73 KB, patch)
2015-12-31 08:22 PST, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
Patch (3.68 KB, patch)
2015-12-31 08:31 PST, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
Patch (8.16 KB, patch)
2015-12-31 09:03 PST, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
Patch (8.91 KB, patch)
2015-12-31 09:18 PST, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-04-22 13:46:34 PDT 
The build should fail if we try to define a default value for an option that doesn't exist.
Comment 1 Michael Catanzaro 2015-04-23 09:14:32 PDT 
We should do this for WEBKIT_OPTION_DEPEND and WEBKIT_OPTION_CONFLICT as well (although perhaps not for the second argument, so that you can make options depend on arbitrary cmake variables).
Comment 2 Michael Catanzaro 2015-12-31 07:25:32 PST 
(In reply to comment #1)
> (although perhaps not for the second argument, so that you can make
> options depend on arbitrary cmake variables).

We don't do this anywhere, so I'll just check to make sure they're all valid options.
Comment 3 Michael Catanzaro 2015-12-31 07:32:50 PST 
Created attachment 268033 [details]
Patch
Comment 4 Michael Catanzaro 2015-12-31 08:00:42 PST 
Created attachment 268036 [details]
Patch
Comment 5 Michael Catanzaro 2015-12-31 08:22:09 PST 
Created attachment 268037 [details]
Patch
Comment 6 Michael Catanzaro 2015-12-31 08:31:09 PST 
Created attachment 268038 [details]
Patch
Comment 7 Michael Catanzaro 2015-12-31 09:03:30 PST 
Created attachment 268040 [details]
Patch
Comment 8 Michael Catanzaro 2015-12-31 09:10:46 PST 
Martin, I reset r? since I had to make a bunch of deletions in OptionsWindows.cmake.

I also added a new option ENABLE_SVG_OTF_CONVERTER, which was set to OFF in OptionsWindows.cmake. (It would be good for someone to investigate turning this ON for Windows, which previously had this turned on at least at some point, if only for Visual Studio builds.)
Comment 9 Michael Catanzaro 2015-12-31 09:18:00 PST 
Created attachment 268041 [details]
Patch
Comment 10 WebKit Commit Bot 2015-12-31 10:50:30 PST 
Comment on attachment 268041 [details]
Patch

Clearing flags on attachment: 268041

Committed r194456: <http://trac.webkit.org/changeset/194456>
Comment 11 WebKit Commit Bot 2015-12-31 10:50:34 PST 
All reviewed patches have been landed.  Closing bug.