Bug 144059

Summary: [CMake] Use lowercase for local variables in macros
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: Tools / TestsAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Trivial CC: commit-queue, mcatanzaro
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 144060    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2015-04-22 11:48:17 PDT
Requested by Martin Robinson, we should use lowercase for local variables inside macros in WebKitFeatures.cmake, as we do in WebKitMacros.cmake.
Attachments
Patch (2.94 KB, patch)
2015-04-22 11:50 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2015-04-22 11:50:06 PDT
Created attachment 251347 [details] Patch
Martin Robinson
Comment 2 2015-04-22 11:51:24 PDT
Comment on attachment 251347 [details] Patch Thanks for the cleanup!
Michael Catanzaro
Comment 3 2015-04-22 11:53:19 PDT
Committed r183116: <http://trac.webkit.org/changeset/183116>
WebKit Commit Bot
Comment 4 2015-04-22 11:59:01 PDT
Re-opened since this is blocked by bug 144060
Michael Catanzaro
Comment 5 2015-04-22 12:02:44 PDT
Comment on attachment 251347 [details] Patch Clearing flags on attachment: 251347 Committed r183120: <http://trac.webkit.org/changeset/183120>
Michael Catanzaro
Comment 6 2015-04-22 12:02:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.