Bug 144059

Summary: [CMake] Use lowercase for local variables in macros
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: Tools / TestsAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Trivial CC: commit-queue, mcatanzaro
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 144060    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Michael Catanzaro 2015-04-22 11:48:17 PDT
Requested by Martin Robinson, we should use lowercase for local variables inside macros in WebKitFeatures.cmake, as we do in WebKitMacros.cmake.
Comment 1 Michael Catanzaro 2015-04-22 11:50:06 PDT
Created attachment 251347 [details]
Patch
Comment 2 Martin Robinson 2015-04-22 11:51:24 PDT
Comment on attachment 251347 [details]
Patch

Thanks for the cleanup!
Comment 3 Michael Catanzaro 2015-04-22 11:53:19 PDT
Committed r183116: <http://trac.webkit.org/changeset/183116>
Comment 4 WebKit Commit Bot 2015-04-22 11:59:01 PDT
Re-opened since this is blocked by bug 144060
Comment 5 Michael Catanzaro 2015-04-22 12:02:44 PDT
Comment on attachment 251347 [details]
Patch

Clearing flags on attachment: 251347

Committed r183120: <http://trac.webkit.org/changeset/183120>
Comment 6 Michael Catanzaro 2015-04-22 12:02:48 PDT
All reviewed patches have been landed.  Closing bug.