Bug 144055

Summary:

Web Inspector: Support passing extra arguments to ContentViews during construction

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	joepeck: review+, timothy: commit-queue-

Timothy Hatcher

Reported 2015-04-22 11:20:51 PDT

This is needed to pass TimelineSidebarPanel to the Timeline views.

Attachments
Patch (30.35 KB, patch) 2015-04-22 11:27 PDT, Timothy Hatcher	joepeck: review+ timothy: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2015-04-22 11:27:18 PDT

Created attachment 251343 [details] Patch

Joseph Pecoraro

Comment 2 2015-04-22 12:54:20 PDT

Comment on attachment 251343 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251343&action=review > Source/WebInspectorUI/ChangeLog:3 > + Web Inspector: Suport passing extra arguments to ContentViews during construction Typo: "Suport" => "Support" > Source/WebInspectorUI/UserInterface/Views/ContentView.js:34 > - return new WebInspector.FrameContentView(representedObject); > + return new WebInspector.FrameContentView(representedObject.mainResource, extraArguments); Related intentional change? This would break some code inside FrameContentView without a related change, since it does: if (this.representedObject.isMainFrame()) Which doesn't make sense on the mainResource.

Timothy Hatcher

Comment 3 2015-04-22 12:56:14 PDT

Comment on attachment 251343 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251343&action=review >> Source/WebInspectorUI/UserInterface/Views/ContentView.js:34 >> + return new WebInspector.FrameContentView(representedObject.mainResource, extraArguments); > > Related intentional change? This would break some code inside FrameContentView without a related change, since it does: > > if (this.representedObject.isMainFrame()) > > Which doesn't make sense on the mainResource. Bad reverse merge on my part. In my tree the end result is: return new WebInspector.ResourceClusterContentView(representedObject.mainResource, extraArguments); FrameContentView will be going away.

Timothy Hatcher

Comment 4 2015-04-25 18:36:14 PDT

r183322 – r183342 http://trac.webkit.org/log/?revs=183322-183342

Note You need to log in before you can comment on or make changes to this bug.