Bug 144029

Summary:

Web Inspector: Vertically misaligned text in Object Trees

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Jonathan Wells <jonowells>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[IMAGE] Issue	none
[PATCH] alignment fix.	none
[IMAGE] Fix.	none

Description Joseph Pecoraro 2015-04-21 18:57:48 PDT

Created attachment 251290 [details]
[IMAGE] Issue

* SUMMARY
Vertically misaligned text in Object Trees. Seen in Yosemite, see attached image.

* STEPS TO REPRODUCE
1. js> window.navigator
2. Expand object tree
  => Fonts look misaligned, especially in the "Prototype" button

* NOTES
- This regressed with bug 143909 / r182982 which switched us to use -webkit-system-font in more places over sans-serif.

Comment 1 Radar WebKit Bug Importer 2015-04-21 18:58:18 PDT

<rdar://problem/20645270>

Comment 2 Joseph Pecoraro 2015-04-21 19:12:55 PDT

We may just be able to remove the "top:2px" from ".object-tree-property > .titles" in ObjectTreePropertyTreeElement.css.

Comment 3 Timothy Hatcher 2015-04-21 20:13:02 PDT

I see a shift in the object name when expanding "▶︎ Object" to "▼ Object". Same thing?

Comment 4 Jonathan Wells 2015-04-25 22:53:41 PDT

(In reply to comment #2)
> We may just be able to remove the "top:2px" from ".object-tree-property >
> .titles" in ObjectTreePropertyTreeElement.css.

top:1px seems to look the best. I'll post a screen.

Comment 5 Jonathan Wells 2015-04-25 23:42:19 PDT

(In reply to comment #4)
> (In reply to comment #2)
> > We may just be able to remove the "top:2px" from ".object-tree-property >
> > .titles" in ObjectTreePropertyTreeElement.css.
> 
> top:1px seems to look the best. I'll post a screen.

You were right, Joe. Removing "top:2px" is correct.

Comment 6 Jonathan Wells 2015-04-25 23:49:49 PDT

Created attachment 251677 [details]
[PATCH] alignment fix.

Comment 7 Jonathan Wells 2015-04-25 23:51:09 PDT

Created attachment 251678 [details]
[IMAGE] Fix.

Comment 8 WebKit Commit Bot 2015-04-26 06:02:10 PDT

Comment on attachment 251677 [details]
[PATCH] alignment fix.

Clearing flags on attachment: 251677

Committed r183352: <http://trac.webkit.org/changeset/183352>

Comment 9 WebKit Commit Bot 2015-04-26 06:02:22 PDT

All reviewed patches have been landed.  Closing bug.