Bug 144017

Summary: Long pause under _takeViewSnapshot when screen updates are disabled
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, commit-queue, sfalken, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Description Tim Horton 2015-04-21 15:25:18 PDT
Long pause under _takeViewSnapshot when screen updates are disabled
Comment 1 Tim Horton 2015-04-21 15:26:13 PDT
Created attachment 251268 [details]
Patch
Comment 2 WebKit Commit Bot 2015-04-21 15:29:16 PDT
Attachment 251268 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:122:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:123:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:177:  The parameter name "cid" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:177:  The parameter name "windowCount" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:177:  The parameter name "options" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 5 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2015-04-21 16:26:23 PDT
http://trac.webkit.org/changeset/183083