| Summary: | Get rid of an unneeded function from LoaderNSURLExtras.mm | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, japhet | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Anders Carlsson
2015-04-21 12:50:55 PDT
Created attachment 251257 [details]
Patch
Does not build?
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Vector.h:904:19: error: use of overloaded operator '==' is ambiguous (with operand types 'const WTF::String' and 'NSString *const')
if (at(i) == value)
~~~~~ ^ ~~~~~
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Vector.h:896:12: note: in instantiation of function template specialization 'WTF::Vector<WTF::String, 0, WTF::CrashOnOverflow>::find<NSString *>' requested here
return find(value) != notFound;
^
/Volumes/Data/EWS/WebKit/Source/WebCore/loader/mac/LoaderNSURLExtras.mm:77:49: note: in instantiation of function template specialization 'WTF::Vector<WTF::String, 0, WTF::CrashOnOverflow>::contains<NSString *>' requested here
if (extensions.isEmpty() || !extensions.contains(extension)) {
^
In file included from /Volumes/Data/EWS/WebKit/Source/WebCore/loader/mac/LoaderNSURLExtras.mm:35:
In file included from /Volumes/Data/EWS/WebKit/Source/WebCore/platform/URL.h:32:
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/text/WTFString.h:484:13: note: candidate function
inline bool operator==(const String& a, const String& b) { return equal(a.impl(), b.impl()); }
Created attachment 251259 [details]
Patch
Comment on attachment 251259 [details]
Patch
r=me
Committed r183074: <http://trac.webkit.org/changeset/183074> |