Bug 144003

Summary: Get rid of an unneeded function from LoaderNSURLExtras.mm
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch cdumez: review+

Anders Carlsson
Reported 2015-04-21 12:50:55 PDT
Get rid of an unneeded function from LoaderNSURLExtras.mm
Attachments
Patch (2.18 KB, patch)
2015-04-21 12:51 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (2.19 KB, patch)
2015-04-21 13:31 PDT, Anders Carlsson 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-04-21 12:51:23 PDT
Created attachment 251257 [details] Patch
Chris Dumez
Comment 2 2015-04-21 13:28:24 PDT
Does not build? /Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Vector.h:904:19: error: use of overloaded operator '==' is ambiguous (with operand types 'const WTF::String' and 'NSString *const') if (at(i) == value) ~~~~~ ^ ~~~~~ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Vector.h:896:12: note: in instantiation of function template specialization 'WTF::Vector<WTF::String, 0, WTF::CrashOnOverflow>::find<NSString *>' requested here return find(value) != notFound; ^ /Volumes/Data/EWS/WebKit/Source/WebCore/loader/mac/LoaderNSURLExtras.mm:77:49: note: in instantiation of function template specialization 'WTF::Vector<WTF::String, 0, WTF::CrashOnOverflow>::contains<NSString *>' requested here if (extensions.isEmpty() || !extensions.contains(extension)) { ^ In file included from /Volumes/Data/EWS/WebKit/Source/WebCore/loader/mac/LoaderNSURLExtras.mm:35: In file included from /Volumes/Data/EWS/WebKit/Source/WebCore/platform/URL.h:32: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/text/WTFString.h:484:13: note: candidate function inline bool operator==(const String& a, const String& b) { return equal(a.impl(), b.impl()); }
Anders Carlsson
Comment 3 2015-04-21 13:31:12 PDT
Created attachment 251259 [details] Patch
Chris Dumez
Comment 4 2015-04-21 13:32:25 PDT
Comment on attachment 251259 [details] Patch r=me
Anders Carlsson
Comment 5 2015-04-21 13:33:54 PDT
Committed r183074: <http://trac.webkit.org/changeset/183074>
Note You need to log in before you can comment on or make changes to this bug.