| Summary: | Rename hasOverride{Height,Width}() to hasOverrideLogicalContent{Height,Width}() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||
| Component: | New Bugs | Assignee: | Manuel Rego Casasnovas <rego> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, commit-queue, darin, esprehn+autocc, glenn, hyatt, kondapallykalyan, svillar | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 251225 [details]
Patch
Adding some reviewers on CC, this is a simple refactoring. Comment on attachment 251225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251225&action=review > Source/WebCore/WebCore.order:6853 > -__ZNK7WebCore9RenderBox17hasOverrideHeightEv > +__ZNK7WebCore9RenderBox17hasOverrideLogicalContentHeightEv No need to ever hand-edit order files; they have to be regenerated by actually running tests with WebKit. If editing this file was needed, this is wrong because the 17 is no longer correct. Created attachment 251307 [details]
Patch for landing
Thanks for the review! (In reply to comment #3) > Comment on attachment 251225 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=251225&action=review > > > Source/WebCore/WebCore.order:6853 > > -__ZNK7WebCore9RenderBox17hasOverrideHeightEv > > +__ZNK7WebCore9RenderBox17hasOverrideLogicalContentHeightEv > > No need to ever hand-edit order files; they have to be regenerated by > actually running tests with WebKit. If editing this file was needed, this is > wrong because the 17 is no longer correct. Yeah, it was manually modified. I only checked that the Mac build worked after the modification, but it also works without any change, so I'm removing this change. Comment on attachment 251307 [details] Patch for landing Clearing flags on attachment: 251307 Committed r183100: <http://trac.webkit.org/changeset/183100> All reviewed patches have been landed. Closing bug. |
Rename hasOverride{Height,Width}() to hasOverrideLogicalContent{Height,Width}()