Bug 143984

Summary: Rename hasOverride{Height,Width}() to hasOverrideLogicalContent{Height,Width}()
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: New BugsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, esprehn+autocc, glenn, hyatt, kondapallykalyan, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Manuel Rego Casasnovas
Reported 2015-04-21 02:16:44 PDT
Rename hasOverride{Height,Width}() to hasOverrideLogicalContent{Height,Width}()
Attachments
Patch (13.71 KB, patch)
2015-04-21 02:23 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.36 KB, patch)
2015-04-22 02:02 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2015-04-21 02:23:04 PDT
Created attachment 251225 [details] Patch
Manuel Rego Casasnovas
Comment 2 2015-04-21 03:10:17 PDT
Adding some reviewers on CC, this is a simple refactoring.
Darin Adler
Comment 3 2015-04-21 08:49:47 PDT
Comment on attachment 251225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251225&action=review > Source/WebCore/WebCore.order:6853 > -__ZNK7WebCore9RenderBox17hasOverrideHeightEv > +__ZNK7WebCore9RenderBox17hasOverrideLogicalContentHeightEv No need to ever hand-edit order files; they have to be regenerated by actually running tests with WebKit. If editing this file was needed, this is wrong because the 17 is no longer correct.
Manuel Rego Casasnovas
Comment 4 2015-04-22 02:02:23 PDT
Created attachment 251307 [details] Patch for landing
Manuel Rego Casasnovas
Comment 5 2015-04-22 02:03:38 PDT
Thanks for the review! (In reply to comment #3) > Comment on attachment 251225 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=251225&action=review > > > Source/WebCore/WebCore.order:6853 > > -__ZNK7WebCore9RenderBox17hasOverrideHeightEv > > +__ZNK7WebCore9RenderBox17hasOverrideLogicalContentHeightEv > > No need to ever hand-edit order files; they have to be regenerated by > actually running tests with WebKit. If editing this file was needed, this is > wrong because the 17 is no longer correct. Yeah, it was manually modified. I only checked that the Mac build worked after the modification, but it also works without any change, so I'm removing this change.
WebKit Commit Bot
Comment 6 2015-04-22 03:32:33 PDT
Comment on attachment 251307 [details] Patch for landing Clearing flags on attachment: 251307 Committed r183100: <http://trac.webkit.org/changeset/183100>
WebKit Commit Bot
Comment 7 2015-04-22 03:32:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.