Bug 143981

Summary: [GTK] jhbuild should not use a branch for openwebrtc
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, pnormand
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
cgarcia: review+
patch for landing
none
patch none

Description Carlos Garcia Campos 2015-04-21 00:36:30 PDT 
It basically means that any commit in that branch can break our build, like it has happened now, see https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/57664/steps/jhbuild/logs/stdio

We should use a tag or a particular revision, never a branch, and this applies to any other module.
Comment 1 Philippe Normand 2015-04-21 00:52:16 PDT 
Created attachment 251222 [details]
patch
Comment 2 Carlos Garcia Campos 2015-04-21 00:58:16 PDT 
Comment on attachment 251222 [details]
patch

Thanks, I'm assuming the EFL change is correct, please wait for EWS just in case
Comment 3 Philippe Normand 2015-04-21 01:07:15 PDT 
Created attachment 251223 [details]
patch for landing
Comment 4 Philippe Normand 2015-04-21 01:14:02 PDT 
Created attachment 251224 [details]
patch
Comment 5 WebKit Commit Bot 2015-04-21 02:58:45 PDT 
Comment on attachment 251224 [details]
patch

Clearing flags on attachment: 251224

Committed r183060: <http://trac.webkit.org/changeset/183060>
Comment 6 WebKit Commit Bot 2015-04-21 02:58:48 PDT 
All reviewed patches have been landed.  Closing bug.