Bug 143969

Summary: Web Inspector: Unify PrettyPrinting Tool and UserInterface resources
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, tobi+webkit, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-04-20 15:37:05 PDT
* SUMMARY Unify PrettyPrinting and UserInterface resources. Step 1, update them so they are equivalent. Step 2, remove the script and just have the PrettyPrinting Tool use UserInterface resources. These fixes are the "misc" changes from Bug 141692 by Tobias Reiss.
Attachments
[PATCH] Proposed Fix (6.70 KB, patch)
2015-04-20 15:38 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (391.45 KB, patch)
2015-04-20 16:14 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (408.14 KB, patch)
2015-04-20 16:16 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-04-20 15:37:26 PDT
<rdar://problem/20624619>
Joseph Pecoraro
Comment 2 2015-04-20 15:38:52 PDT
Created attachment 251194 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2015-04-20 16:08:40 PDT
Comment on attachment 251194 [details] [PATCH] Proposed Fix Never mind this, I'm just going to do everything all at once, since it is rather easy.
Joseph Pecoraro
Comment 4 2015-04-20 16:14:20 PDT
Created attachment 251198 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 5 2015-04-20 16:16:34 PDT
Created attachment 251200 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 6 2015-04-20 20:46:55 PDT
Comment on attachment 251200 [details] [PATCH] Proposed Fix Good call.
WebKit Commit Bot
Comment 7 2015-04-20 21:36:52 PDT
Comment on attachment 251200 [details] [PATCH] Proposed Fix Clearing flags on attachment: 251200 Committed r183043: <http://trac.webkit.org/changeset/183043>
WebKit Commit Bot
Comment 8 2015-04-20 21:36:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.