Summary: | Context menu doesn't account for selection semantics | ||
---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | buildbot, commit-queue, rniwa |
Priority: | P2 | Keywords: | InRadar |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | 144021 | ||
Bug Blocks: | |||
Attachments: |
Description
Brent Fulgham
2015-04-20 11:59:47 PDT
Created attachment 251247 [details]
Patch
Comment on attachment 251247 [details] Patch Attachment 251247 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4708163676798976 Number of test failures exceeded the failure limit. Created attachment 251249 [details]
Archive of layout-test-results from ews102 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Uh oh! Looks like I introduced some crashes. Will fix. Comment on attachment 251247 [details] Patch Attachment 251247 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4863398290391040 Number of test failures exceeded the failure limit. Created attachment 251253 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Committed r183077: <http://trac.webkit.org/changeset/183077> Re-opened since this is blocked by bug 144021 Created attachment 251345 [details]
Patch v2 (Test Fixes)
Comment on attachment 251345 [details]
Patch v2 (Test Fixes)
Revised patch as follows:
1. Dictionary lookup was not honoring standard WebKit editing rules for handling hit tests at end-of-line, end-of-paragraph, etc.
2. The new dictionary lookup was not retaining trailing spaces when asked to by the system.
3. Rebaselined one test for the new dictionary-lookup behavior.
Looks like I'll also need to rebaseline some tests based on the Mavericks bot output. Comment on attachment 251345 [details] Patch v2 (Test Fixes) Attachment 251345 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6495054554202112 New failing tests: editing/selection/select-from-textfield-outwards.html editing/selection/doubleclick-beside-cr-span.html Created attachment 251348 [details]
Archive of layout-test-results from ews103 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 251345 [details] Patch v2 (Test Fixes) Attachment 251345 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6563398422626304 New failing tests: editing/selection/select-from-textfield-outwards.html Created attachment 251355 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 251367 [details]
Patch (v3 Don't touch regular selection)
Comment on attachment 251367 [details]
Patch (v3 Don't touch regular selection)
Revised the patch to only affect context menu operations. This corrected the five failing tests.
Comment on attachment 251367 [details]
Patch (v3 Don't touch regular selection)
You could probably write a test.
Committed r183138: <http://trac.webkit.org/changeset/183138> (In reply to comment #19) > Comment on attachment 251367 [details] > Patch (v3 Don't touch regular selection) > > You could probably write a test. Test added during landing! :-) |