| Summary: | Update RefPtr documentation and deprecation | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | Web Template Framework | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, kling, koivisto, mjs, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2015-04-19 11:25:03 PDT
Created attachment 251120 [details]
Patch
This is actually just a start; I had a hard time figuring out what to say in the documentation. Comment on attachment 251120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251120&action=review Thank you very much for these updates. r=me with some minor glitches fixed. > Websites/webkit.org/coding/RefPtr.html:115 > +<p>The title starts with a reference count of 1. The <span class="function">setTitle</span> function stores it in the data member, > +and the reference count is increments to 1. Then the local variable <span class="variable">untitledTitle</span> goes out of > +scope and the reference count is decremented back to 1.</p> is increments to 1 -> is incremented to 2 > Websites/webkit.org/coding/RefPtr.html:249 > +examine or modify the refernece count.</p> refernece -> reference > Websites/webkit.org/coding/RefPtr.html:333 > +Not all getters need to take an rvalue reference.</li> Not all getters -> Not all setters Committed r183001: <http://trac.webkit.org/changeset/183001> |