Bug 143913

Summary:

[JSC] Add support for typed arrays to the Array profiling

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, fpizlo, ggaren

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	fpizlo: review+

Description Benjamin Poulain 2015-04-17 21:29:30 PDT

Add support for typed arrays to the Array profiling

Comment 1 Benjamin Poulain 2015-04-17 21:29:55 PDT

Created attachment 251082 [details]
Patch

Comment 2 Geoffrey Garen 2015-04-20 11:13:02 PDT

Comment on attachment 251082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251082&action=review

Patch looks good to me. Is this ready to land?

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:764
> -        
> +

Revert.

Comment 3 Benjamin Poulain 2015-04-27 17:22:51 PDT

Created attachment 251794 [details]
Patch

Comment 4 Filip Pizlo 2015-04-27 20:19:05 PDT

Comment on attachment 251794 [details]
Patch

Microbenchmark?  It would be great to have a microbenchmark in LayoutTests/js/regress/script-tests so that it'll run as part of JSRegress in run-jsc-benchmarks.

Comment 5 Benjamin Poulain 2015-04-27 21:17:32 PDT

Committed r183450: <http://trac.webkit.org/changeset/183450>

Comment 6 Andy Estes 2015-04-28 07:45:09 PDT

(In reply to comment #5)
> Committed r183450: <http://trac.webkit.org/changeset/183450>

The new test is missing an expected result, so I added the actual result from Yosemite in http://trac.webkit.org/changeset/183473. You might want to check if that's right.