Bug 143913

Summary: [JSC] Add support for typed arrays to the Array profiling
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, fpizlo, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch fpizlo: review+

Benjamin Poulain
Reported 2015-04-17 21:29:30 PDT
Add support for typed arrays to the Array profiling
Attachments
Patch (13.86 KB, patch)
2015-04-17 21:29 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (20.61 KB, patch)
2015-04-27 17:22 PDT, Benjamin Poulain 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2015-04-17 21:29:55 PDT
Created attachment 251082 [details] Patch
Geoffrey Garen
Comment 2 2015-04-20 11:13:02 PDT
Comment on attachment 251082 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251082&action=review Patch looks good to me. Is this ready to land? > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:764 > - > + Revert.
Benjamin Poulain
Comment 3 2015-04-27 17:22:51 PDT
Created attachment 251794 [details] Patch
Filip Pizlo
Comment 4 2015-04-27 20:19:05 PDT
Comment on attachment 251794 [details] Patch Microbenchmark? It would be great to have a microbenchmark in LayoutTests/js/regress/script-tests so that it'll run as part of JSRegress in run-jsc-benchmarks.
Benjamin Poulain
Comment 5 2015-04-27 21:17:32 PDT
Committed r183450: <http://trac.webkit.org/changeset/183450>
Andy Estes
Comment 6 2015-04-28 07:45:09 PDT
(In reply to comment #5) > Committed r183450: <http://trac.webkit.org/changeset/183450> The new test is missing an expected result, so I added the actual result from Yosemite in http://trac.webkit.org/changeset/183473. You might want to check if that's right.
Note You need to log in before you can comment on or make changes to this bug.