| Summary: | [Mac] Support -apple-system-* on OS X | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | commit-queue, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Myles C. Maxfield
2015-04-17 16:43:33 PDT
Created attachment 251070 [details]
Patch
Attachment 251070 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:10: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 251070 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251070&action=review > Source/WebCore/ChangeLog:10 > + No new tests (OOPS!). Need to port over iOS's tests. > Source/WebCore/platform/graphics/mac/FontCacheMac.mm:41 > +#import "RenderThemeMac.h" Layering violation! |