Bug 143869

Summary: [GStreamer] Silent WebAudio buffers support
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, commit-queue, pnormand, slomo, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 166922    
Bug Blocks:    
Attachments:
Description Flags
patch
none
Patch cgarcia: review+

Philippe Normand
Reported 2015-04-17 02:45:17 PDT
Would be nice to set the GAP flag on silent buffers before pushing them to appsrc.
Attachments
patch (1.84 KB, patch)
2015-04-17 02:52 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (1.77 KB, patch)
2018-01-31 07:46 PST, Philippe Normand 		cgarcia: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2015-04-17 02:52:57 PDT
Created attachment 251012 [details] patch
Philippe Normand
Comment 2 2015-04-17 03:45:05 PDT
Committed r182947: <http://trac.webkit.org/changeset/182947>
WebKit Commit Bot
Comment 3 2017-01-11 01:05:30 PST
Re-opened since this is blocked by bug 166922
Zan Dobersek
Comment 4 2017-08-21 04:01:11 PDT
Problem that caused the roll-out was reported in bug #166884.
Philippe Normand
Comment 5 2017-09-04 02:34:21 PDT
It would be interesting to debug this leak. Might be a bug in GStreamer's baseaudiosink.
Philippe Normand
Comment 6 2018-01-31 07:46:54 PST
Created attachment 332761 [details] Patch
Philippe Normand
Comment 7 2018-01-31 08:14:47 PST
Committed r227902: <https://trac.webkit.org/changeset/227902>
Radar WebKit Bug Importer
Comment 8 2018-01-31 08:17:33 PST
<rdar://problem/37070729>
Note You need to log in before you can comment on or make changes to this bug.