Bug 143844

Summary:

Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	mitz: review+

Description Anders Carlsson 2015-04-16 14:09:28 PDT

Deprecated _WKWebsiteDataStore in favor of WKWebsiteDataStore

Comment 1 Anders Carlsson 2015-04-16 15:08:08 PDT

Created attachment 250951 [details]
Patch

Comment 2 WebKit Commit Bot 2015-04-16 15:10:15 PDT

Attachment 250951 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:447:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:454:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:456:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Anders Carlsson 2015-04-16 16:03:33 PDT

Created attachment 250965 [details]
Patch

Comment 4 WebKit Commit Bot 2015-04-16 16:05:01 PDT

Attachment 250965 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:447:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:454:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:456:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Anders Carlsson 2015-04-16 16:50:28 PDT

Created attachment 250979 [details]
Patch

Comment 6 WebKit Commit Bot 2015-04-16 16:52:05 PDT

Attachment 250979 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:447:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:454:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:456:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 mitz 2015-04-16 17:22:54 PDT

Comment on attachment 250979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250979&action=review

> Source/WebKit2/mac/postprocess-framework-headers.sh:56
> +            sed -i .tmp -e s/^WK_CLASS_AVAILABLE/NS_CLASS_AVAILABLE/ -e s/WK_AVAILABLE/NS_AVAILABLE/ -es/^WK_CLASS_DEPRECATED/NS_CLASS_DEPRECATED/ -e s/WK_DEPRECATED/NS_DEPRECATED/ -e s/WK_DESIGNATED_INITIALIZER/NS_DESIGNATED_INITIALIZER/ -e s/WK_ENUM_AVAILABLE/NS_ENUM_AVAILABLE/ -e s/WK_UNAVAILABLE/NS_UNAVAILABLE/ -e s/WK_ASSUME_NONNULL_BEGIN/NS_ASSUME_NONNULL_BEGIN/ -e s/WK_ASSUME_NONNULL_END/NS_ASSUME_NONNULL_END/ -e s/WK_NULLABLE_PROPERTY/nullable,/ -e s/WK_NULLABLE_SPECIFIER/__nullable/g -e s/WK_NULLABLE/nullable/g -e s/WK_NULL_UNSPECIFIED/null_unspecified/ ${TARGET_TEMP_DIR}/${HEADER_PATH##*/} || exit $_

-es => -e s

Comment 8 Anders Carlsson 2015-04-16 17:47:19 PDT

Committed r182930: <http://trac.webkit.org/changeset/182930>