RESOLVED FIXED 143844
Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore 
https://bugs.webkit.org/show_bug.cgi?id=143844
Summary Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
Anders Carlsson
Reported 2015-04-16 14:09:28 PDT
Deprecated _WKWebsiteDataStore in favor of WKWebsiteDataStore
Attachments
Patch (11.84 KB, patch)
2015-04-16 15:08 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (12.41 KB, patch)
2015-04-16 16:03 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (13.03 KB, patch)
2015-04-16 16:50 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-04-16 15:08:08 PDT
Created attachment 250951 [details] Patch
WebKit Commit Bot
Comment 2 2015-04-16 15:10:15 PDT
Attachment 250951 [details] did not pass style-queue: ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:447: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:454: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:456: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2015-04-16 16:03:33 PDT
Created attachment 250965 [details] Patch
WebKit Commit Bot
Comment 4 2015-04-16 16:05:01 PDT
Attachment 250965 [details] did not pass style-queue: ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:447: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:454: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:456: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 5 2015-04-16 16:50:28 PDT
Created attachment 250979 [details] Patch
WebKit Commit Bot
Comment 6 2015-04-16 16:52:05 PDT
Attachment 250979 [details] did not pass style-queue: ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:447: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:454: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:456: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 7 2015-04-16 17:22:54 PDT
Comment on attachment 250979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250979&action=review > Source/WebKit2/mac/postprocess-framework-headers.sh:56 > + sed -i .tmp -e s/^WK_CLASS_AVAILABLE/NS_CLASS_AVAILABLE/ -e s/WK_AVAILABLE/NS_AVAILABLE/ -es/^WK_CLASS_DEPRECATED/NS_CLASS_DEPRECATED/ -e s/WK_DEPRECATED/NS_DEPRECATED/ -e s/WK_DESIGNATED_INITIALIZER/NS_DESIGNATED_INITIALIZER/ -e s/WK_ENUM_AVAILABLE/NS_ENUM_AVAILABLE/ -e s/WK_UNAVAILABLE/NS_UNAVAILABLE/ -e s/WK_ASSUME_NONNULL_BEGIN/NS_ASSUME_NONNULL_BEGIN/ -e s/WK_ASSUME_NONNULL_END/NS_ASSUME_NONNULL_END/ -e s/WK_NULLABLE_PROPERTY/nullable,/ -e s/WK_NULLABLE_SPECIFIER/__nullable/g -e s/WK_NULLABLE/nullable/g -e s/WK_NULL_UNSPECIFIED/null_unspecified/ ${TARGET_TEMP_DIR}/${HEADER_PATH##*/} || exit $_ -es => -e s
Anders Carlsson
Comment 8 2015-04-16 17:47:19 PDT
Committed r182930: <http://trac.webkit.org/changeset/182930>
Note You need to log in before you can comment on or make changes to this bug.