Bug 143827

Summary: [GStreamer] improve video rendering stats
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, sergio, slomo, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch calvaris: review+

Philippe Normand
Reported 2015-04-16 06:14:41 PDT
Since we know exactly which samples are rendered by the player we could easily gather statistics about dropped frames and rendered frames. Right now we depend on the fpsdisplaysink for that... Instead we could: 1) before replacing the sample stored in player, check if it was rendered by fetching some bool variable from its qdata 2) when rendering set the bool variable in qdata to TRUE
Attachments
Patch (9.98 KB, patch)
2020-01-14 01:45 PST, Philippe Normand 		calvaris: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-01-14 01:45:44 PST
Created attachment 387635 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2020-01-14 03:39:59 PST
Comment on attachment 387635 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387635&action=review > Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:314 > + break; We can maybe ASSERT_NOT_REACHED here.
Philippe Normand
Comment 3 2020-01-14 06:52:41 PST
Committed r254507: <https://trac.webkit.org/changeset/254507>
Radar WebKit Bug Importer
Comment 4 2020-01-14 06:53:15 PST
<rdar://problem/58566720>
Note You need to log in before you can comment on or make changes to this bug.