| Summary: | Web Inspector: Give DOM Nodes a Context Menu to Log Element to the console | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | burg, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Joseph Pecoraro
2015-04-15 21:12:25 PDT
Created attachment 250895 [details]
[PATCH] Proposed Fix
Comment on attachment 250895 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=250895&action=review r=me Nice! Great to see a simple added use case to the console API. This change will be helpful reference. > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:59 > + this._domTreeOutline = new WebInspector.DOMTreeOutline(true, true, true); In a separate patch, we should convert these boolean arguments into setters. There's no reason they need to be constructor arguments. Comment on attachment 250895 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=250895&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js:496 > + var text = WebInspector.UIString("Selected Element"); The more we do this the more I think the text needs a special formatting. Italics? Tokenized? |