| Summary: | Make WKWebsiteDataStore public | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, mitz | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Anders Carlsson
2015-04-15 15:39:12 PDT
Created attachment 250877 [details]
Patch
Attachment 250877 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:210: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 250877 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250877&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:294 > + webPageConfiguration.websiteDataStore = &((WKWebsiteDataStore *)[_configuration _websiteDataStore])->_websiteDataStore->websiteDataStore(); Do we need this already? > Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.h:31 > + Need WK_ASSUME_NONNULL_BEGIN/END around the rest of this header. > Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.h:36 > ++ (instancetype)defaultDataStore; The return type here should be WKWebsiteDataStore *, not instancetype. > Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:32 > +#import "WKNSArray.h" Doesn’t this one import APIArray.h? > Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:37 > ++ (instancetype)defaultDataStore Fix the return type. Created attachment 250882 [details]
Patch
Attachment 250882 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:210: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 250882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250882&action=review Something is off with the whitespace but I can’t quite put my finger on it. > Source/WebKit2/ChangeLog:9 > + @interface and @implementation that just derives from WKWebsiteDataStore. There’s a little more to _WKWebsiteDataStore in this version of the patch. > Source/WebKit2/ChangeLog:18 > + * UIProcess/API/Cocoa/WKWebsiteDataStore.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataStore.h. You should mention the other changes: stricter return types and unavailability of -init. > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:294 > + webPageConfiguration.websiteDataStore = &((WKWebsiteDataStore *)[_configuration _websiteDataStore])->_websiteDataStore->websiteDataStore(); This remains a mystery to me. > Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:27 > +#include "config.h" > +#include "_WKWebsiteDataStore.h" #import Committed r182873: <http://trac.webkit.org/changeset/182873> |