Bug 143797

Summary:

Media control buttons should be transparent white normally, opaque white when selected, and have no drop shadow

Product:

WebKit

Reporter:

Roger Fong <roger_fong>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	dino: review+

Description Roger Fong 2015-04-15 14:43:46 PDT

rdar://problem/20083708

Comment 1 Roger Fong 2015-04-15 22:36:11 PDT

Created attachment 250900 [details]
patch

Comment 2 Roger Fong 2015-04-16 00:38:39 PDT

I meant for my changelog title to be:
Adjustments to button graphics for media controls.

Comment 3 Dean Jackson 2015-04-16 11:51:54 PDT

Comment on attachment 250900 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250900&action=review

> Source/WebCore/ChangeLog:13
> +        Visual appearance changes to buttons.
> +        No text shadow.
> +        Use plus-lighter blending mode and change button opacity.
> +        Make buttons opaque white when active.
> +        * Modules/mediacontrols/mediaControlsApple.css:

Could you rewrite this as a paragraph? Also, you need a blank line between that and the list of files.

Comment 4 Roger Fong 2015-04-16 12:25:56 PDT

Done. http://trac.webkit.org/changeset/182900