Bug 143797 - Media control buttons should be transparent white normally, opaque white when selected, and have no drop shadow
Summary: Media control buttons should be transparent white normally, opaque white when...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-15 14:43 PDT by Roger Fong
Modified: 2015-04-16 12:25 PDT (History)
2 users (show)

See Also:

Attachments
patch (35.70 KB, patch)
2015-04-15 22:36 PDT, Roger Fong 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2015-04-15 14:43:46 PDT 
rdar://problem/20083708
Comment 1 Roger Fong 2015-04-15 22:36:11 PDT 
Created attachment 250900 [details]
patch
Comment 2 Roger Fong 2015-04-16 00:38:39 PDT 
I meant for my changelog title to be:
Adjustments to button graphics for media controls.
Comment 3 Dean Jackson 2015-04-16 11:51:54 PDT 
Comment on attachment 250900 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250900&action=review

> Source/WebCore/ChangeLog:13
> +        Visual appearance changes to buttons.
> +        No text shadow.
> +        Use plus-lighter blending mode and change button opacity.
> +        Make buttons opaque white when active.
> +        * Modules/mediacontrols/mediaControlsApple.css:

Could you rewrite this as a paragraph? Also, you need a blank line between that and the list of files.
Comment 4 Roger Fong 2015-04-16 12:25:56 PDT 
Done. http://trac.webkit.org/changeset/182900