| Summary: | Sites with both width=device-width and height=device-height load zoomed out | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, dbates, sam, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| URL: | InRadar | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 156504 | ||||||||
| Attachments: |
|
||||||||
|
Description
Tim Horton
2015-04-15 13:56:32 PDT
Created attachment 250855 [details]
Patch
Comment on attachment 250855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250855&action=review > Source/WebCore/page/ViewportConfiguration.cpp:122 > + if (m_viewportArguments.height == ViewportArguments::ValueDeviceHeight && m_viewportArguments.width != ViewportArguments::ValueDeviceWidth) We should be even more aggressive. Where are the tests? ;) Created attachment 250883 [details]
Patch
(In reply to comment #2) > Comment on attachment 250855 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=250855&action=review > > > Source/WebCore/page/ViewportConfiguration.cpp:122 > > + if (m_viewportArguments.height == ViewportArguments::ValueDeviceHeight && m_viewportArguments.width != ViewportArguments::ValueDeviceWidth) > > We should be even more aggressive. OK! Done. > Where are the tests? ;) Hopefully we can have tests soon, after WKTR uses WKWebView always. |