Bug 143795

Summary: Sites with both width=device-width and height=device-height load zoomed out
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, dbates, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: InRadar
Bug Depends on:    
Bug Blocks: 156504    
Attachments:
Description Flags
Patch
none
Patch benjamin: review+

Tim Horton
Reported 2015-04-15 13:56:32 PDT
Sites with both width=device-width and height=device-height load zoomed out
Attachments
Patch (2.22 KB, patch)
2015-04-15 13:56 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (2.23 KB, patch)
2015-04-15 17:05 PDT, Tim Horton 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-04-15 13:56:50 PDT
Created attachment 250855 [details] Patch
Benjamin Poulain
Comment 2 2015-04-15 15:36:41 PDT
Comment on attachment 250855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250855&action=review > Source/WebCore/page/ViewportConfiguration.cpp:122 > + if (m_viewportArguments.height == ViewportArguments::ValueDeviceHeight && m_viewportArguments.width != ViewportArguments::ValueDeviceWidth) We should be even more aggressive. Where are the tests? ;)
Tim Horton
Comment 3 2015-04-15 17:05:14 PDT
Created attachment 250883 [details] Patch
Tim Horton
Comment 4 2015-04-16 13:38:11 PDT
(In reply to comment #2) > Comment on attachment 250855 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=250855&action=review > > > Source/WebCore/page/ViewportConfiguration.cpp:122 > > + if (m_viewportArguments.height == ViewportArguments::ValueDeviceHeight && m_viewportArguments.width != ViewportArguments::ValueDeviceWidth) > > We should be even more aggressive. OK! Done. > Where are the tests? ;) Hopefully we can have tests soon, after WKTR uses WKWebView always.
Tim Horton
Comment 5 2015-04-16 14:25:42 PDT
http://trac.webkit.org/changeset/182910
Daniel Bates
Comment 6 2015-04-16 14:28:18 PDT
<rdar://problem/20369671>
Note You need to log in before you can comment on or make changes to this bug.