Bug 143792

Summary:

Harden DFGForAllKills

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

143734

Attachments:

Description	Flags
the patch	ggaren: review+

Description Filip Pizlo 2015-04-15 12:10:19 PDT

Currently it appears to have issues with:

- Bytecode instructions that don't have an origin in DFG IR because the operations were killed off.

- MovHint doing a kill because the local is always live.

Comment 1 Filip Pizlo 2015-04-15 12:15:36 PDT

Created attachment 250833 [details]
the patch

Comment 2 Geoffrey Garen 2015-04-15 13:09:50 PDT

Comment on attachment 250833 [details]
the patch

r=me

Comment 3 Filip Pizlo 2015-04-15 13:34:05 PDT

Landed in http://trac.webkit.org/changeset/182857