Bug 143787

Summary: Clean up: Have SVGTextLayoutEngine::beginTextPathLayout() take a reference to a RenderSVGTextPath instead of a pointer
Product: WebKit Reporter: Daniel Bates <dbates>
Component: SVGAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, sabouhallawa, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Daniel Bates 2015-04-15 11:04:34 PDT 
Currently SVGTextLayoutEngine::beginTextPathLayout() takes a pointer to a RenderObject and run-time asserts that its non-null and assumes that it can be safely downcast to a reference to RenderSVGTextPath object. Instead we should have SVGTextLayoutEngine::beginTextPathLayout() take a reference to a RenderSVGTextPath to better catch at compile time and document the preconditions of this function.
Comment 1 Daniel Bates 2015-04-15 11:14:31 PDT 
Created attachment 250826 [details]
Patch
Comment 2 Andreas Kling 2015-04-15 15:16:24 PDT 
Comment on attachment 250826 [details]
Patch

r=me
Comment 3 Daniel Bates 2015-04-15 15:36:42 PDT 
Comment on attachment 250826 [details]
Patch

Clearing flags on attachment: 250826

Committed r182864: <http://trac.webkit.org/changeset/182864>
Comment 4 Daniel Bates 2015-04-15 15:36:48 PDT 
All reviewed patches have been landed.  Closing bug.