Bug 143772

Summary: [W32] GCC warns that dummy HeapStatistics has a noreturn function that returns
Product: WebKit Reporter: LRN <lrn1986>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: beidson, cgarcia, lrn1986
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 133028    
Attachments:
Description Flags
Fixup dummy HeapStatistics implementation beidson: review-

Description LRN 2015-04-15 06:34:06 PDT
GCC warns that exitWithFailure is marked as noreturn, but it does return:
../webkitgtk-2.4.8/Source/JavaScriptCore/heap/HeapStatistics.cpp:135:1: warning: 'noreturn' function does return
Comment 1 LRN 2015-04-15 10:16:19 PDT
Created attachment 250819 [details]
Fixup dummy HeapStatistics implementation

GCC warns that exitWithFailure is marked as noreturn, but it does return:
../webkitgtk-2.4.8/Source/JavaScriptCore/heap/HeapStatistics.cpp:135:1: warning: 'noreturn' function does return

Call exit(-1) to indicate that no, there is no returning from here.
Comment 2 Brady Eidson 2017-04-24 19:07:09 PDT
Comment on attachment 250819 [details]
Fixup dummy HeapStatistics implementation

This patch has been pending review since 2015 with no recent activity.
It seems unlikely that it would even still apply to trunk in its current form.

Clearing from the review queue.

Feel free to update and resubmit if the patch is still relevant.