Bug 143764

Summary: [W32][GTK] GI fails due to W32-incompatible arguments to the scanner
Product: WebKit Reporter: LRN <lrn1986>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, lrn1986
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 133028    
Attachments:
Description Flags
Use correct .la files as --library arguments for GI scanner cgarcia: review+, cgarcia: commit-queue-

LRN
Reported 2015-04-15 06:27:48 PDT
It is given --library=webkitgtk-@WEBKITGTK_API_VERSION@ --library=javascriptcoregtk-@WEBKITGTK_API_VERSION@ which doesn't work. Instead it should be given --library=libwebkitgtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la --library=libjavascriptcoregtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la which works.
Attachments
Use correct .la files as --library arguments for GI scanner (2.41 KB, patch)
2015-04-15 10:01 PDT, LRN 		cgarcia: review+
cgarcia: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
LRN
Comment 1 2015-04-15 10:01:10 PDT
Created attachment 250810 [details] Use correct .la files as --library arguments for GI scanner This way it plays well with W32 gobject-introspection library resolution code. Without that one would get things like: ERROR: can't resolve libraries to shared libraries: webkitgtk-3.0, javascriptcoregtk-3.0
Carlos Garcia Campos
Comment 2 2015-05-18 11:26:23 PDT
Committed to 2.4 http://trac.webkit.org/changeset/184504
Note You need to log in before you can comment on or make changes to this bug.