| Summary: | [GTK][W32] FileSystemGtk calls GetModuleHandleExA(), but does not include appropriate header | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | LRN <lrn1986> | ||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED WORKSFORME | ||||||||
| Severity: | Normal | CC: | aperez, bugs-noreply, cgarcia, commit-queue, lrn1986 | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 133028 | ||||||||
| Attachments: |
|
||||||||
|
Description
LRN
2015-04-15 06:20:54 PDT
Created attachment 250804 [details]
Add missing includes to FileSystemGtk
Needed for GetModuleHandleExA() & Co.
Attachment 250804 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:12: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 250839 [details]
Add missing includes to FileSystemGtk
Needed for GetModuleHandleExA() & Co.
Committed to 2.4 http://trac.webkit.org/changeset/184549 I'm leaving this open, since this applies to trunk as well, but for trunk I think we should probably remove the windows implementation from FileSystemGtk instead, since it's currently dead code. Comment on attachment 250804 [details] Add missing includes to FileSystemGtk Cleared Darin Adler's review+ from obsolete attachment 250804 [details] so that this bug does not appear in http://webkit.org/pending-commit. The source has since been moved into Source/WTF/wtf/glib/FileSystemGlib.cpp which does include <windows.h> guarded by OS(WINDOWS) these days — the issue reported in this bug does no longer exist. |