Bug 143755

Summary: [W32] Buildsystem may use wrong Python interpreter
Product: WebKit Reporter: LRN <lrn1986>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, lrn1986
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 133028    
Attachments:
Description Flags
[W32] Use confgured Python interpreter
none
Use confgured Python interpreter cgarcia: review+, cgarcia: commit-queue-

Description LRN 2015-04-15 06:15:27 PDT
Configure script has tests for Python (AC_PATH_PROG(PYTHON, python)), but makefiles just say "python" and let make finds whatever there is in PATH, so a wrong version of Python might be used. Mingw-python,
for example, which has commandline length limit, which results in
errors like:
/usr/bin/env: python: Argument list too long
GNUmakefile:82317: recipe for target
'DerivedSources/WebInspectorUI/GResourceBundle.xml' failed
Comment 1 LRN 2015-04-15 08:40:21 PDT
Created attachment 250790 [details]
[W32] Use confgured Python interpreter

Configure script has tests for Python (AC_PATH_PROG(PYTHON, python)),
use the interpretor they provide (which is overridable by user by
the way of passing PYTHON=... to configure) instead of the first
thing found in PATH.

Otherwise wrong version of Python might be used. Mingw-python,
for example, which has commandline length limit, which results in
errors like:
/usr/bin/env: python: Argument list too long
GNUmakefile:82317: recipe for target
'DerivedSources/WebInspectorUI/GResourceBundle.xml' failed
Comment 2 LRN 2015-04-15 09:42:39 PDT
Created attachment 250798 [details]
Use confgured Python interpreter

Configure script has tests for Python (AC_PATH_PROG(PYTHON, python)),
use the interpretor they provide (which is overridable by user by
the way of passing PYTHON=... to configure) instead of the first
thing found in PATH.

Otherwise wrong version of Python might be used. Mingw-python,
for example, which has commandline length limit, which results in
errors like:
/usr/bin/env: python: Argument list too long
GNUmakefile:82317: recipe for target
'DerivedSources/WebInspectorUI/GResourceBundle.xml' failed
Comment 3 Carlos Garcia Campos 2015-05-18 23:43:32 PDT
Committed to 2.4 http://trac.webkit.org/changeset/184551