Summary: | Regression(r180020): Web Inspector crashes on pages that have a stylesheet with an invalid MIME type | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | CSS | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, bfulgham, joepeck | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 141501 | ||||||
Attachments: |
|
Description
Chris Dumez
2015-04-14 17:29:04 PDT
Created attachment 250767 [details]
Patch
Comment on attachment 250767 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250767&action=review r=me! > Source/WebCore/ChangeLog:10 > + are not served with a CSS MIME type. Showing the Web inspector on a Nit: "Showing the Web inspector" => "Showing Web Inspector" > Source/WebCore/inspector/InspectorPageAgent.cpp:159 > + // This can return a null String if the MIME type is invalid. This comment should be on the line above. "This" is sheetText. > LayoutTests/http/tests/inspector/css/bad-mime-type-expected.txt:1 > +Tests showing the Web Inspector on a page that has a stylesheet with an invalid MIME type. Grammar: How about: "Tests that showing Web Inspector on a page that has a stylesheet with an invalid MIME type does not crash." Committed r182829: <http://trac.webkit.org/changeset/182829> This test always times out on Windows: https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fcss%2Fbad-mime-type.html > FAIL: Timed out waiting for notifyDone to be called
Joe, do I need to do anything special for Windows?
Comment on attachment 250767 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250767&action=review > LayoutTests/http/tests/inspector/css/bad-mime-type.html:12 > + InspectorTest.completeTest(); This test cannot get much simpler than this. I don't know why Windows would time out. Maybe completeTest() needs to be called in a setTimeout() for some reason? |