Bug 143732

Summary:

Correct layering violation in DumpRenderTree Build

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Tools / Tests

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

143684

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Brent Fulgham 2015-04-14 15:19:40 PDT

In Bug 143286, I introduced a layering violation between DumpRenderTree and WebCore. Instead of accessing WebCore types directly, DRT needs to pass through the WebCoreTestSupport library to manipulate WebCore state.

Comment 1 Brent Fulgham 2015-04-14 16:02:24 PDT

Created attachment 250750 [details]
Patch

Comment 2 Brent Fulgham 2015-04-14 16:48:58 PDT

Committed r182821: <http://trac.webkit.org/changeset/182821>