Bug 143726

Summary:

Add SPI to clear HSTS hosts added since a date

Product:

WebKit

Reporter:

Brian Weinstein <bweinstein>

Component:

WebKit API

Assignee:

Brian Weinstein <bweinstein>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Fix	andersca: review+, commit-queue: commit-queue-
[PATCH] Fix with CFNetworkSPI.h	andersca: review+, andersca: commit-queue+
[PATCH] Fix v3	beidson: review+, buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-mavericks	none

Brian Weinstein

Reported 2015-04-14 14:15:29 PDT

We need SPI to clear HSTS hosts added since a date. rdar://problem/16664597

Attachments
[PATCH] Fix (4.20 KB, patch) 2015-04-14 14:17 PDT, Brian Weinstein	andersca: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
[PATCH] Fix with CFNetworkSPI.h (5.13 KB, patch) 2015-04-14 15:15 PDT, Brian Weinstein	andersca: review+ andersca: commit-queue+	Details Formatted Diff Diff
[PATCH] Fix v3 (5.13 KB, patch) 2015-04-14 15:37 PDT, Brian Weinstein	beidson: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-mavericks (523.15 KB, application/zip) 2015-04-14 15:52 PDT, Build Bot	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Brian Weinstein

Comment 1 2015-04-14 14:17:54 PDT

Created attachment 250739 [details] [PATCH] Fix

WebKit Commit Bot

Comment 2 2015-04-14 15:04:43 PDT

Comment on attachment 250739 [details] [PATCH] Fix Rejecting attachment 250739 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ase/DerivedSources/WebKit2/WebProcessProxyMessageReceiver.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit2.build/Release/WebKit.build/Objects-normal/x86_64/WebProcessProxyMessageReceiver.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit2.build/Release/WebKit.build/Objects-normal/x86_64/WebProcessPoolCocoa.o UIProcess/Cocoa/WebProcessPoolCocoa.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.appspot.com/results/6701337739788288

Brian Weinstein

Comment 3 2015-04-14 15:08:09 PDT

Oops. I’ll send out a new patch shortly that uses CFNetworkSPI.h instead of directly trying to import CFURLProtocolPriv.h.

Brian Weinstein

Comment 4 2015-04-14 15:15:01 PDT

Created attachment 250744 [details] [PATCH] Fix with CFNetworkSPI.h

Brian Weinstein

Comment 5 2015-04-14 15:37:58 PDT

Created attachment 250747 [details] [PATCH] Fix v3

Build Bot

Comment 6 2015-04-14 15:52:15 PDT

Comment on attachment 250747 [details] [PATCH] Fix v3 Attachment 250747 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4930151208976384 New failing tests: compositing/scrolling/touch-scroll-to-clip.html

Build Bot

Comment 7 2015-04-14 15:52:18 PDT

Created attachment 250748 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5

Brian Weinstein

Comment 8 2015-04-14 16:14:14 PDT

Committed in r182815.

Note You need to log in before you can comment on or make changes to this bug.