| Summary: | Insert volume control in correct place after exiting wireless play | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Roger Fong <roger_fong> | ||||
| Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, eric.carlson, roger_fong | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Roger Fong
2015-04-14 12:55:24 PDT
Created attachment 250728 [details]
patch
Comment on attachment 250728 [details]
patch
Maybe we should use "display: none" styling to hide and show rather than DOM manipulation. That’s usually better if you want to preserve a certain ordering of the nodes.
Roger that. Didn't realize that display: none actually removes things from the DOM. http://trac.webkit.org/changeset/182812 (In reply to comment #3) > Roger that. Didn't realize that display: none actually removes things from > the DOM. It doesn’t remove things from the DOM. It removes them from the render tree, though, which usually accomplishes the same thing. |