Bug 143721

Summary: Insert volume control in correct place after exiting wireless play
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch darin: review+

Roger Fong
Reported 2015-04-14 12:55:24 PDT
rdar://problem/20526106
Attachments
patch (1.67 KB, patch)
2015-04-14 12:57 PDT, Roger Fong 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2015-04-14 12:57:47 PDT
Created attachment 250728 [details] patch
Darin Adler
Comment 2 2015-04-14 13:19:41 PDT
Comment on attachment 250728 [details] patch Maybe we should use "display: none" styling to hide and show rather than DOM manipulation. That’s usually better if you want to preserve a certain ordering of the nodes.
Roger Fong
Comment 3 2015-04-14 14:36:47 PDT
Roger that. Didn't realize that display: none actually removes things from the DOM. http://trac.webkit.org/changeset/182812
Darin Adler
Comment 4 2015-04-14 15:39:27 PDT
(In reply to comment #3) > Roger that. Didn't realize that display: none actually removes things from > the DOM. It doesn’t remove things from the DOM. It removes them from the render tree, though, which usually accomplishes the same thing.
Note You need to log in before you can comment on or make changes to this bug.