Bug 143697

Summary:

fast/sub-pixel/input-caret-on-subpixel-bound.html is flaky

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, zalan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	none

Description Alexey Proskuryakov 2015-04-13 22:31:02 PDT

fast/sub-pixel/input-caret-on-subpixel-bound.html is flaky on debug WK2 bots. It's a reftest for editing, and caret is not drawn in actual result sometimes.

There is a race between a caret blinking timer, and a timer in the test.

Comment 1 Alexey Proskuryakov 2015-04-13 22:34:17 PDT

Created attachment 250694 [details]
proposed fix

I have a vague memory of us doing something special to always have the caret draw when dumping pixel results, but I cannot find any sign of that in the code.

Comment 2 Alexey Proskuryakov 2015-04-13 22:44:35 PDT

There is a function in FrameSelection named setCaretBlinks which we could potentially call from Internals, but it's completely unused now, and may or may not work.

Looks like it was accidentally added when upstreaming iOS code.

Comment 3 Alexey Proskuryakov 2015-04-14 09:48:24 PDT

We should probably delete setCaretBlinks and supporting code, and if we want to disable blinking during tests, we should do that by supporting and tweaking NSTextInsertionPointBlinkPeriod/NSTextInsertionPointBlinkPeriodOn/NSTextInsertionPointBlinkPeriodOff.

Comment 4 WebKit Commit Bot 2015-04-14 10:35:05 PDT

Comment on attachment 250694 [details]
proposed fix

Clearing flags on attachment: 250694

Committed r182801: <http://trac.webkit.org/changeset/182801>

Comment 5 WebKit Commit Bot 2015-04-14 10:35:09 PDT

All reviewed patches have been landed.  Closing bug.