Bug 143696

Summary:

Clean up: Share more code between asynchronous and synchronous NSTextInputClient code paths

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

ap, commit-queue, dbates

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
Patch	ap: review+

Daniel Bates

Reported 2015-04-13 22:27:23 PDT

We should share more code between the asynchronous and synchronous NSTextInputClient code paths.

Attachments
Patch (10.20 KB, patch) 2015-04-13 22:29 PDT, Daniel Bates	ap: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2015-04-13 22:29:12 PDT

Created attachment 250693 [details] Patch

WebKit Commit Bot

Comment 2 2015-04-13 22:32:24 PDT

Attachment 250693 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2285: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2307: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2345: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2386: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alexey Proskuryakov

Comment 3 2015-04-13 22:40:16 PDT

Comment on attachment 250693 [details] Patch rs=me

Note You need to log in before you can comment on or make changes to this bug.