Bug 143696

Summary:

Clean up: Share more code between asynchronous and synchronous NSTextInputClient code paths

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

ap, commit-queue, dbates

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
Patch	ap: review+

Description Daniel Bates 2015-04-13 22:27:23 PDT

We should share more code between the asynchronous and synchronous NSTextInputClient code paths.

Comment 1 Daniel Bates 2015-04-13 22:29:12 PDT

Created attachment 250693 [details]
Patch

Comment 2 WebKit Commit Bot 2015-04-13 22:32:24 PDT

Attachment 250693 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2285:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2307:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2345:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:2386:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Alexey Proskuryakov 2015-04-13 22:40:16 PDT

Comment on attachment 250693 [details]
Patch

rs=me