Bug 143691

Summary: Replace JavaScriptCoreOutputConsoleMessagesToSystemConsole default with an SPI
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, joepeck, msaboff, timothy
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix
timothy: review+, timothy: commit-queue-
[PATCH] Proposed Fix ggaren: review+

Joseph Pecoraro
Reported 2015-04-13 19:35:53 PDT
* SUMMARY Replace JavaScriptCoreOutputConsoleMessagesToSystemConsole default with an SPI. Accessing the default using CFPreferences comes with a non-trivial amount of memory and overhead. It would be nice to get off of the preferences API here and move to something simpler, like an SPI. There can be different approaches here: - Global log to system console setting - matches the existing default - Per context log to system console setting - more fine grained control Seeing as the existing value was global, lets just make a global setting for this as well.
Attachments
[PATCH] Proposed Fix (5.71 KB, patch)
2015-04-13 19:39 PDT, Joseph Pecoraro 		timothy: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (5.82 KB, patch)
2015-04-14 17:37 PDT, Joseph Pecoraro 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-04-13 19:39:07 PDT
Created attachment 250689 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2015-04-13 19:40:27 PDT
<rdar://problem/20470092>
Timothy Hatcher
Comment 3 2015-04-13 20:31:25 PDT
Comment on attachment 250689 [details] [PATCH] Proposed Fix Are there any clients that need to adopt? Safari?
Joseph Pecoraro
Comment 4 2015-04-14 17:37:46 PDT
Created attachment 250765 [details] [PATCH] Proposed Fix Better version. This moves the setting to the new JSRemoteInspector.h private header and renames it to JSRemoteInspectorSetLogToSystemConsole.
Geoffrey Garen
Comment 5 2015-04-14 17:45:31 PDT
Comment on attachment 250765 [details] [PATCH] Proposed Fix r=me
Joseph Pecoraro
Comment 6 2015-04-14 17:48:48 PDT
http://trac.webkit.org/changeset/182826
Note You need to log in before you can comment on or make changes to this bug.