Bug 143687

Summary: Keep track of each shared memory object's protection when deciding whether to return our existing port
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Anders Carlsson
Reported 2015-04-13 18:00:42 PDT
Keep track of each shared memory object's protection when deciding whether to return our existing port
Attachments
Patch (4.86 KB, patch)
2015-04-13 18:01 PDT, Anders Carlsson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-04-13 18:01:51 PDT
Created attachment 250685 [details] Patch
Anders Carlsson
Comment 2 2015-04-13 18:34:48 PDT
Committed r182774: <http://trac.webkit.org/changeset/182774>
Brent Fulgham
Comment 3 2015-04-14 10:28:17 PDT
This patch is making the Debug Windows bot go crazy with errors. Why!?! Can you please fix?!?
Brent Fulgham
Comment 5 2015-04-14 10:31:25 PDT
Whoops! False alarm -- it was Chris's patch that landed just prior to yours. Nothing to see here. Carry on...
Anders Carlsson
Comment 6 2015-04-14 10:40:06 PDT
(In reply to comment #5) > Whoops! False alarm -- it was Chris's patch that landed just prior to yours. > Nothing to see here. Carry on... Right. Pro tip: If a patch only touches WebKit2 it's impossible for it to cause crashes on Windows ;)
Note You need to log in before you can comment on or make changes to this bug.