Bug 143687

Summary:

Keep track of each shared memory object's protection when deciding whether to return our existing port

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Anders Carlsson 2015-04-13 18:00:42 PDT

Keep track of each shared memory object's protection when deciding whether to return our existing port

Comment 1 Anders Carlsson 2015-04-13 18:01:51 PDT

Created attachment 250685 [details]
Patch

Comment 2 Anders Carlsson 2015-04-13 18:34:48 PDT

Committed r182774: <http://trac.webkit.org/changeset/182774>

Comment 3 Brent Fulgham 2015-04-14 10:28:17 PDT

This patch is making the Debug Windows bot go crazy with errors. Why!?! Can you please fix?!?

Comment 4 Brent Fulgham 2015-04-14 10:28:58 PDT

Crash Crash Crash:

https://build.webkit.org/results/Apple%20Win%207%20Debug%20(Tests)/r182774%20(65688)/results.html

Comment 5 Brent Fulgham 2015-04-14 10:31:25 PDT

Whoops! False alarm -- it was Chris's patch that landed just prior to yours. Nothing to see here. Carry on...

Comment 6 Anders Carlsson 2015-04-14 10:40:06 PDT

(In reply to comment #5)
> Whoops! False alarm -- it was Chris's patch that landed just prior to yours.
> Nothing to see here. Carry on...

Right. Pro tip: If a patch only touches WebKit2 it's impossible for it to cause crashes on Windows ;)