Bug 143687 - Keep track of each shared memory object's protection when deciding whether to return our existing port
Summary: Keep track of each shared memory object's protection when deciding whether to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-13 18:00 PDT by Anders Carlsson
Modified: 2015-04-14 10:40 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.86 KB, patch)
2015-04-13 18:01 PDT, Anders Carlsson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-04-13 18:00:42 PDT 
Keep track of each shared memory object's protection when deciding whether to return our existing port
Comment 1 Anders Carlsson 2015-04-13 18:01:51 PDT 
Created attachment 250685 [details]
Patch
Comment 2 Anders Carlsson 2015-04-13 18:34:48 PDT 
Committed r182774: <http://trac.webkit.org/changeset/182774>
Comment 3 Brent Fulgham 2015-04-14 10:28:17 PDT 
This patch is making the Debug Windows bot go crazy with errors. Why!?! Can you please fix?!?
Comment 5 Brent Fulgham 2015-04-14 10:31:25 PDT 
Whoops! False alarm -- it was Chris's patch that landed just prior to yours. Nothing to see here. Carry on...
Comment 6 Anders Carlsson 2015-04-14 10:40:06 PDT 
(In reply to comment #5)
> Whoops! False alarm -- it was Chris's patch that landed just prior to yours.
> Nothing to see here. Carry on...

Right. Pro tip: If a patch only touches WebKit2 it's impossible for it to cause crashes on Windows ;)