Bug 143671 – imported/w3c/canvas/2d.text.measure.width.empty.html is flaky

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

We lack waitUntilDone/notifyDone for imported tests.

canvas/philip/tests/2d.text.measure.width.empty.html is good, but imported/w3c/canvas/2d.text.measure.width.empty.html usually fails (and only flakily passes on slow bots).

[Alexey Proskuryakov]

Created attachment 250653 [details]
proposed fix

I don't know if it's correct to fix imported W3C tests like this, or if there is a script somewhere that would overwrite the fixes later.

[youenn fablet]

(In reply to comment #1)
> Created attachment 250653 [details]
> proposed fix
> 
> I don't know if it's correct to fix imported W3C tests like this, or if
> there is a script somewhere that would overwrite the fixes later.

I encountered in the past some WPT tests that were missing testharness.js and testharnessreport.js includes. That may be a nicer way to handling such issues.
How is the latest WPT version?

In general, I would not recommend to modify scripts with webkit specific directives.

[Alexey Proskuryakov]

> In general, I would not recommend to modify scripts with webkit specific directives.

Do you have a suggestion for how to fix this issue in a better way?

[youenn fablet]

(In reply to comment #3)
> > In general, I would not recommend to modify scripts with webkit specific directives.
> 
> Do you have a suggestion for how to fix this issue in a better way?

If am not mistaken, the corresponding test is https://github.com/w3c/web-platform-tests/blob/master/2dcontext/drawing-text-to-the-canvas/2d.text.measure.width.empty.html
It now includes testharness.js/testharnessreport.js scripts.

Reimporting that test should solve the issue.
If it were me, I would reimport it into LayoutTests/imported/w3c/web-platform-tests/2dcontext

[Alexey Proskuryakov]

Created attachment 250675 [details]
proposed fix

OK, updated the test from trunk. I don't know how to import, so I just copy/pasted it and updated the relative links.

Note that we already have some local edits related to testRunner in canvas-tests though, we should probably undo that at some point in the future.

[WebKit Commit Bot]

Comment on attachment 250675 [details]
proposed fix

Clearing flags on attachment: 250675

Committed r182769: <http://trac.webkit.org/changeset/182769>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.