Bug 143665

Summary: [cmake] REGRESSION(182663): It broke feature dependency handling
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Critical CC: commit-queue, mcatanzaro, mrobinson
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 143596    
Attachments:
Description Flags
[cmake] REGRESSION(182663): It broke feature dependency handling none

Description Csaba Osztrogonác 2015-04-13 06:24:13 PDT 
Before http://trac.webkit.org/changeset/182663 the EFL --minimal build worked fine,
because ENABLE_ENCRYPTED_MEDIA_V2 and ENABLE_MEDIA_CONTROLS_SCRIPT were disabled
automatically by cmake:
-- Disabling ENABLE_ENCRYPTED_MEDIA_V2 since ENABLE_VIDEO support is disabled.
-- Disabling ENABLE_MEDIA_CONTROLS_SCRIPT since ENABLE_VIDEO support is disabled.

But r182663 made something wrong, because these options aren't 
disabled automatically which cause build failure.

Could you check what was going wrong?
Comment 1 Michael Catanzaro 2015-04-13 08:43:08 PDT 
Created attachment 250640 [details]
[cmake] REGRESSION(182663): It broke feature dependency handling
Comment 2 Michael Catanzaro 2015-04-13 08:44:02 PDT 
This *isn't tested* because I have to run right now. I'll test it later today.
Comment 3 Csaba Osztrogonác 2015-04-13 08:55:42 PDT 
Comment on attachment 250640 [details]
[cmake] REGRESSION(182663): It broke feature dependency handling

Thanks for the patch, it looks reasonable and fixes the issue I reported.
If you can't see any other issue, feel free to land it.
Comment 4 WebKit Commit Bot 2015-04-13 10:43:38 PDT 
Comment on attachment 250640 [details]
[cmake] REGRESSION(182663): It broke feature dependency handling

Clearing flags on attachment: 250640

Committed r182740: <http://trac.webkit.org/changeset/182740>
Comment 5 WebKit Commit Bot 2015-04-13 10:43:43 PDT 
All reviewed patches have been landed.  Closing bug.