Bug 143655

Summary: Fixed position element is truncated if moved onscreen by a transform
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, dino, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Description Simon Fraser (smfr) 2015-04-12 21:53:47 PDT
Fixed position element is truncated if moved onscreen by a transform
Comment 1 Simon Fraser (smfr) 2015-04-12 21:56:35 PDT
Created attachment 250623 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-04-12 21:57:54 PDT
rdar://problem/15020044
Comment 3 Darin Adler 2015-04-13 09:40:45 PDT
Comment on attachment 250623 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250623&action=review

> Source/WebCore/rendering/style/RenderStyle.cpp:485
> +        if (rareNonInheritedData->m_transform.get() != other.rareNonInheritedData->m_transform.get()) {

I’m surprised the get() are needed here.

> Source/WebCore/rendering/style/RenderStyle.cpp:488
> +            if (*rareNonInheritedData->m_transform.get() != *other.rareNonInheritedData->m_transform.get()) {

The get() should not be needed here.
Comment 4 Simon Fraser (smfr) 2015-04-13 10:56:29 PDT
https://trac.webkit.org/r182743