Bug 143634

Summary: Run flaky conservative GC related test first before polluting stack and registers
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, commit-queue, darin, fpizlo, ggaren, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Yusuke Suzuki 2015-04-11 10:41:58 PDT
Run flaky conservative GC related test first before polluting stack and registers
Comment 1 Yusuke Suzuki 2015-04-11 10:48:53 PDT
Created attachment 250575 [details]
Patch
Comment 2 Yusuke Suzuki 2015-04-11 10:51:08 PDT
This patch fixes https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20JSC%20%28Tests%29?numbuilds=25 failures. However, we cannot avoid this flakiness completely since JSC GC is conservative.
Comment 3 Ryosuke Niwa 2015-04-11 11:51:03 PDT
Comment on attachment 250575 [details]
Patch

It's sad that we can't test more realistic scenario but I can't think of a way around it.
Comment 4 WebKit Commit Bot 2015-04-11 12:44:32 PDT
Comment on attachment 250575 [details]
Patch

Clearing flags on attachment: 250575

Committed r182661: <http://trac.webkit.org/changeset/182661>
Comment 5 WebKit Commit Bot 2015-04-11 12:44:38 PDT
All reviewed patches have been landed.  Closing bug.