| Summary: | Update gesture swipe shadow style | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | andersca, bdakin, sam, simon.fraser | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Tim Horton
2015-04-10 12:56:35 PDT
Created attachment 250528 [details]
Patch
Created attachment 250534 [details]
Patch
Comment on attachment 250534 [details]
Patch
Going to make some changes.
Created attachment 250556 [details]
Patch
Comment on attachment 250556 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250556&action=review A little surprised that the resources are not listed in the change log. Seems a little archaic that we have a 2x and a “regular” version of this. Not really sure why we don’t need a 3x and why we do need a 1x. > Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:625 > + [m_swipeDimmingLayer setName:@"Gesture Swipe Dimming Layer"]; > + [m_swipeDimmingLayer setBackgroundColor:[NSColor blackColor].CGColor]; > + [m_swipeDimmingLayer setOpacity:swipeOverlayDimmingOpacity]; > + [m_swipeDimmingLayer setAnchorPoint:CGPointZero]; > + [m_swipeDimmingLayer setFrame:dimmingRect]; > + [m_swipeDimmingLayer setGeometryFlipped:geometryIsFlippedToRoot]; > + [m_swipeDimmingLayer setDelegate:[WebActionDisablingCALayerDelegate shared]]; I’m surprised that we are using method call syntax rather than property setting syntax here. Comment on attachment 250556 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250556&action=review It sounds like we might get a CAGradientLayer instead of the PNGs soon, so hopefully the point about the resources will be rendered moot. That said, this is Mac code so that should explain why 1x and not 3x. >> Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:625 >> + [m_swipeDimmingLayer setDelegate:[WebActionDisablingCALayerDelegate shared]]; > > I’m surprised that we are using method call syntax rather than property setting syntax here. They're RetainPtrs. My understanding is that we prefer [x setY:z] over x.get().y = z, but sadly I don't think that's written down anywhere. |