Bug 143597

Summary:

[Curl] Small improvements to CurlCacheEntry::parseResponseHeaders()

Product:

WebKit

Reporter:

Sungmann Cho <sungmann.cho>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, galpeter, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Sungmann Cho

Reported 2015-04-09 22:53:33 PDT

Most lines of code in CurlCacheEntry::parseResponseHeaders() don't need to be executed if the response has "no-cache" or "no-store" directive, but we are checking these conditions in the middle of the method. We can move this to the beginning of the method for efficiency.

Attachments
Patch (2.41 KB, patch) 2015-04-09 22:55 PDT, Sungmann Cho	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Sungmann Cho

Comment 1 2015-04-09 22:55:11 PDT

Created attachment 250501 [details] Patch

Csaba Osztrogonác

Comment 2 2015-04-13 04:45:32 PDT

Comment on attachment 250501 [details] Patch LGTM, r=me.

WebKit Commit Bot

Comment 3 2015-04-13 07:06:37 PDT

Comment on attachment 250501 [details] Patch Clearing flags on attachment: 250501 Committed r182729: <http://trac.webkit.org/changeset/182729>

WebKit Commit Bot

Comment 4 2015-04-13 07:06:42 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.